From 24caa2cfcd8da73d82d163ca3cb8b9bdb945dd4b Mon Sep 17 00:00:00 2001
From: Maxim Filippov <colixer@gmail.com>
Date: Thu, 13 Dec 2018 05:00:01 +0300
Subject: Add generateProfileLink

---
 .../user_profile_link_generator/user_profile_link_generator.js | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 src/services/user_profile_link_generator/user_profile_link_generator.js

(limited to 'src/services')

diff --git a/src/services/user_profile_link_generator/user_profile_link_generator.js b/src/services/user_profile_link_generator/user_profile_link_generator.js
new file mode 100644
index 00000000..88e0ec38
--- /dev/null
+++ b/src/services/user_profile_link_generator/user_profile_link_generator.js
@@ -0,0 +1,10 @@
+const generateProfileLink = (user, name = '') => {
+  const baseLinkParams = { name: 'user-profile' }
+  const { id } = user
+
+  return { ...baseLinkParams, params: (isExternal(user) ? { id } : { name }) }
+}
+
+const isExternal = ({screen_name}) => (screen_name.indexOf('@') > 0)
+
+export default generateProfileLink
-- 
cgit v1.2.3-70-g09d2


From 7ffb7e67952101d530eda23a33acc0f4aa4e22a8 Mon Sep 17 00:00:00 2001
From: Maxim Filippov <colixer@gmail.com>
Date: Thu, 13 Dec 2018 13:51:47 +0300
Subject: Use "-1" in indexOf

---
 src/services/user_profile_link_generator/user_profile_link_generator.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/services')

diff --git a/src/services/user_profile_link_generator/user_profile_link_generator.js b/src/services/user_profile_link_generator/user_profile_link_generator.js
index 88e0ec38..1a2ea472 100644
--- a/src/services/user_profile_link_generator/user_profile_link_generator.js
+++ b/src/services/user_profile_link_generator/user_profile_link_generator.js
@@ -5,6 +5,6 @@ const generateProfileLink = (user, name = '') => {
   return { ...baseLinkParams, params: (isExternal(user) ? { id } : { name }) }
 }
 
-const isExternal = ({screen_name}) => (screen_name.indexOf('@') > 0)
+const isExternal = ({screen_name}) => (screen_name.indexOf('@') > -1)
 
 export default generateProfileLink
-- 
cgit v1.2.3-70-g09d2


From e4a34cc4d4dcd882e8a546813215dcac95e4ceab Mon Sep 17 00:00:00 2001
From: Maxim Filippov <colixer@gmail.com>
Date: Thu, 13 Dec 2018 19:57:11 +0300
Subject: Use 'userProfileLink' to generate user-profile link

---
 src/components/chat_panel/chat_panel.js                      |  2 +-
 src/components/chat_panel/chat_panel.vue                     |  9 ++++-----
 src/components/notification/notification.js                  |  4 ++++
 src/components/notification/notification.vue                 |  4 +++-
 src/components/status/status.js                              |  4 ++++
 src/components/status/status.vue                             | 12 +++++++++---
 src/components/user_card/user_card.js                        |  6 ++++++
 src/components/user_card/user_card.vue                       |  3 ++-
 src/components/user_card_content/user_card_content.js        |  4 ++++
 src/components/user_card_content/user_card_content.vue       |  4 ++--
 src/components/who_to_follow_panel/who_to_follow_panel.js    |  4 ++++
 src/components/who_to_follow_panel/who_to_follow_panel.vue   |  6 +++---
 .../user_profile_link_generator.js                           | 12 ++++++------
 .../user_profile_link_generator.spec.js                      | 12 ++++++------
 14 files changed, 58 insertions(+), 28 deletions(-)

(limited to 'src/services')

diff --git a/src/components/chat_panel/chat_panel.js b/src/components/chat_panel/chat_panel.js
index 959b5c3a..e649e907 100644
--- a/src/components/chat_panel/chat_panel.js
+++ b/src/components/chat_panel/chat_panel.js
@@ -13,7 +13,7 @@ const chatPanel = {
       return this.$store.state.chat.messages
     },
     userProfileLink (user) {
-      return generateProfileLink(user, user.name)
+      return generateProfileLink(user.id, user.screen_name)
     }
   },
   methods: {
diff --git a/src/components/chat_panel/chat_panel.vue b/src/components/chat_panel/chat_panel.vue
index 182ea347..b253342e 100644
--- a/src/components/chat_panel/chat_panel.vue
+++ b/src/components/chat_panel/chat_panel.vue
@@ -13,8 +13,10 @@
             <img :src="message.author.avatar" />
           </span>
           <div class="chat-content">
-            <router-link class="chat-name" :to="userProfileLink(message.author)">
-              {{message.author.username}}
+            <router-link
+              class="chat-name"
+              :to="userProfileLink(message.author)">
+                {{message.author.username}}
             </router-link>
             <br>
             <span class="chat-text">
@@ -67,9 +69,6 @@
   overflow-x: hidden;
 }
 
-.chat-name {
-}
-
 .chat-message {
   display: flex;
   padding: 0.2em 0.5em
diff --git a/src/components/notification/notification.js b/src/components/notification/notification.js
index c786f2cc..95d094f4 100644
--- a/src/components/notification/notification.js
+++ b/src/components/notification/notification.js
@@ -2,6 +2,7 @@ import Status from '../status/status.vue'
 import StillImage from '../still-image/still-image.vue'
 import UserCardContent from '../user_card_content/user_card_content.vue'
 import { highlightClass, highlightStyle } from '../../services/user_highlighter/user_highlighter.js'
+import generateProfileLink from 'src/services/user_profile_link_generator/user_profile_link_generator'
 
 const Notification = {
   data () {
@@ -28,6 +29,9 @@ const Notification = {
       const highlight = this.$store.state.config.highlight
       const user = this.notification.action.user
       return highlightStyle(highlight[user.screen_name])
+    },
+    userProfileLink (user) {
+      return generateProfileLink(user.id, user.screen_name)
     }
   }
 }
diff --git a/src/components/notification/notification.vue b/src/components/notification/notification.vue
index 40146513..a34301b7 100644
--- a/src/components/notification/notification.vue
+++ b/src/components/notification/notification.vue
@@ -28,7 +28,9 @@
         <small class="timeago"><router-link v-if="notification.status" :to="{ name: 'conversation', params: { id: notification.status.id } }"><timeago :since="notification.action.created_at" :auto-update="240"></timeago></router-link></small>
       </span>
       <div class="follow-text" v-if="notification.type === 'follow'">
-        <router-link :to="{ name: 'user-profile', params: { name: notification.action.user.screen_name } }">@{{notification.action.user.screen_name}}</router-link>
+        <router-link :to="userProfileLink(notification.action.user)">
+          @{{notification.action.user.screen_name}}
+        </router-link>
       </div>
       <template v-else>
         <status v-if="notification.status"  class="faint" :compact="true" :statusoid="notification.status" :noHeading="true"></status>
diff --git a/src/components/status/status.js b/src/components/status/status.js
index ad6f4184..fbf99a23 100644
--- a/src/components/status/status.js
+++ b/src/components/status/status.js
@@ -7,6 +7,7 @@ import UserCardContent from '../user_card_content/user_card_content.vue'
 import StillImage from '../still-image/still-image.vue'
 import { filter, find } from 'lodash'
 import { highlightClass, highlightStyle } from '../../services/user_highlighter/user_highlighter.js'
+import generateProfileLink from 'src/services/user_profile_link_generator/user_profile_link_generator'
 
 const Status = {
   name: 'Status',
@@ -203,6 +204,9 @@ const Status = {
         return 'small'
       }
       return 'normal'
+    },
+    userProfileLink (id, name) {
+      return generateProfileLink(id, name)
     }
   },
   components: {
diff --git a/src/components/status/status.vue b/src/components/status/status.vue
index 2ef9074e..f51d9b79 100644
--- a/src/components/status/status.vue
+++ b/src/components/status/status.vue
@@ -2,7 +2,11 @@
   <div class="status-el" v-if="!hideReply && !deleted" :class="[{ 'status-el_focused': isFocused }, { 'status-conversation': inlineExpanded }]">
     <template v-if="muted && !noReplyLinks">
       <div class="media status container muted">
-        <small><router-link :to="{ name: 'user-profile', params: { name: status.user.screen_name } }">{{status.user.screen_name}}</router-link></small>
+        <small>
+          <router-link :to="userProfileLink(status.user.id, status.user.screen_name)">
+            {{status.user.screen_name}}
+          </router-link>
+        </small>
         <small class="muteWords">{{muteWordHits.join(', ')}}</small>
         <a href="#" class="unmute" @click.prevent="toggleMute"><i class="icon-eye-off"></i></a>
       </div>
@@ -34,10 +38,12 @@
                 <h4 class="user-name" v-if="status.user.name_html" v-html="status.user.name_html"></h4>
                 <h4 class="user-name" v-else>{{status.user.name}}</h4>
                 <span class="links">
-                  <router-link :to="{ name: 'user-profile', params: { name: status.user.screen_name } }">{{status.user.screen_name}}</router-link>
+                  <router-link :to="userProfileLink(status.user.id, status.user.screen_name)">
+                    {{status.user.screen_name}}
+                  </router-link>
                   <span v-if="status.in_reply_to_screen_name" class="faint reply-info">
                     <i class="icon-right-open"></i>
-                    <router-link :to="{ name: 'user-profile', params: { id: status.in_reply_to_screen_name } }">
+                    <router-link :to="userProfileLink(status.in_reply_to_user_id, status.in_reply_to_screen_name)">
                       {{status.in_reply_to_screen_name}}
                     </router-link>
                   </span>
diff --git a/src/components/user_card/user_card.js b/src/components/user_card/user_card.js
index a019627a..5d9089ae 100644
--- a/src/components/user_card/user_card.js
+++ b/src/components/user_card/user_card.js
@@ -1,4 +1,5 @@
 import UserCardContent from '../user_card_content/user_card_content.vue'
+import generateProfileLink from 'src/services/user_profile_link_generator/user_profile_link_generator'
 
 const UserCard = {
   props: [
@@ -26,6 +27,11 @@ const UserCard = {
       this.$store.state.api.backendInteractor.denyUser(this.user.id)
       this.$store.dispatch('removeFollowRequest', this.user)
     }
+  },
+  computed: {
+    userProfileLink (user) {
+      return generateProfileLink(user.id, user.screen_name)
+    }
   }
 }
 
diff --git a/src/components/user_card/user_card.vue b/src/components/user_card/user_card.vue
index 3e1a7205..40f04f25 100644
--- a/src/components/user_card/user_card.vue
+++ b/src/components/user_card/user_card.vue
@@ -19,7 +19,8 @@
           {{ $t('user_card.follows_you') }}
         </span>
       </div>
-      <router-link class='user-screen-name' :to="{ name: 'user-profile', params: { name: user.screen_name } }">
+
+      <router-link class='user-screen-name' :to="userProfileLink(user)">
         @{{user.screen_name}}
       </router-link>
     </div>
diff --git a/src/components/user_card_content/user_card_content.js b/src/components/user_card_content/user_card_content.js
index d22d4ec1..abdac58e 100644
--- a/src/components/user_card_content/user_card_content.js
+++ b/src/components/user_card_content/user_card_content.js
@@ -1,5 +1,6 @@
 import StillImage from '../still-image/still-image.vue'
 import { hex2rgb } from '../../services/color_convert/color_convert.js'
+import generateProfileLink from 'src/services/user_profile_link_generator/user_profile_link_generator'
 
 export default {
   props: [ 'user', 'switcher', 'selected', 'hideBio', 'activatePanel' ],
@@ -40,6 +41,9 @@ export default {
       const days = Math.ceil((new Date() - new Date(this.user.created_at)) / (60 * 60 * 24 * 1000))
       return Math.round(this.user.statuses_count / days)
     },
+    userProfileLink (user) {
+      return generateProfileLink(user.id, user.screen_name)
+    },
     userHighlightType: {
       get () {
         const data = this.$store.state.config.highlight[this.user.screen_name]
diff --git a/src/components/user_card_content/user_card_content.vue b/src/components/user_card_content/user_card_content.vue
index bde1d139..6e48f3f9 100644
--- a/src/components/user_card_content/user_card_content.vue
+++ b/src/components/user_card_content/user_card_content.vue
@@ -9,13 +9,13 @@
         <i class="icon-link-ext usersettings"></i>
       </a>
       <div class='container'>
-        <router-link :to="{ name: 'user-profile', params: { name: user.screen_name } }">
+        <router-link :to="userProfileLink(user)">
           <StillImage class="avatar" :src="user.profile_image_url_original"/>
         </router-link>
         <div class="name-and-screen-name">
           <div :title="user.name" class='user-name' v-if="user.name_html" v-html="user.name_html"></div>
           <div :title="user.name" class='user-name' v-else>{{user.name}}</div>
-          <router-link class='user-screen-name' :to="{ name: 'user-profile', params: { name: user.screen_name } }">
+          <router-link class='user-screen-name' :to="userProfileLink(user)">
             <span>@{{user.screen_name}}</span><span v-if="user.locked"><i class="icon icon-lock"></i></span>
             <span v-if="!hideUserStatsLocal" class="dailyAvg">{{dailyAvg}} {{ $t('user_card.per_day') }}</span>
           </router-link>
diff --git a/src/components/who_to_follow_panel/who_to_follow_panel.js b/src/components/who_to_follow_panel/who_to_follow_panel.js
index 49b8f5b6..4507d9e5 100644
--- a/src/components/who_to_follow_panel/who_to_follow_panel.js
+++ b/src/components/who_to_follow_panel/who_to_follow_panel.js
@@ -1,4 +1,5 @@
 import apiService from '../../services/api/api.service.js'
+import generateProfileLink from 'src/services/user_profile_link_generator/user_profile_link_generator'
 
 function showWhoToFollow (panel, reply) {
   var users = reply
@@ -91,6 +92,9 @@ const WhoToFollowPanel = {
     },
     suggestionsEnabled () {
       return this.$store.state.instance.suggestionsEnabled
+    },
+    userProfileLink (id, name) {
+      return generateProfileLink(id, name)
     }
   },
   watch: {
diff --git a/src/components/who_to_follow_panel/who_to_follow_panel.vue b/src/components/who_to_follow_panel/who_to_follow_panel.vue
index 35722ffa..a62e8360 100644
--- a/src/components/who_to_follow_panel/who_to_follow_panel.vue
+++ b/src/components/who_to_follow_panel/who_to_follow_panel.vue
@@ -8,9 +8,9 @@
       </div>
       <div class="panel-body who-to-follow">
         <p>
-          <img v-bind:src="img1"/> <router-link :to="{ name: 'user-profile', params: { name: name1 } }">{{ name1 }}</router-link><br>
-          <img v-bind:src="img2"/> <router-link :to="{ name: 'user-profile', params: { name: name2 } }">{{ name2 }}</router-link><br>
-          <img v-bind:src="img3"/> <router-link :to="{ name: 'user-profile', params: { name: name3 } }">{{ name3 }}</router-link><br>
+          <img v-bind:src="img1"/> <router-link :to="userProfileLink(id1, name1)">{{ name1 }}</router-link><br>
+          <img v-bind:src="img2"/> <router-link :to="userProfileLink(id2, name2)">{{ name2 }}</router-link><br>
+          <img v-bind:src="img3"/> <router-link :to="userProfileLink(id3, name3)">{{ name3 }}</router-link><br>
           <img v-bind:src="$store.state.instance.logo"> <a v-bind:href="moreUrl" target="_blank">{{$t('who_to_follow.more')}}</a>
         </p>
       </div>
diff --git a/src/services/user_profile_link_generator/user_profile_link_generator.js b/src/services/user_profile_link_generator/user_profile_link_generator.js
index 1a2ea472..3e245b15 100644
--- a/src/services/user_profile_link_generator/user_profile_link_generator.js
+++ b/src/services/user_profile_link_generator/user_profile_link_generator.js
@@ -1,10 +1,10 @@
-const generateProfileLink = (user, name = '') => {
-  const baseLinkParams = { name: 'user-profile' }
-  const { id } = user
-
-  return { ...baseLinkParams, params: (isExternal(user) ? { id } : { name }) }
+const generateProfileLink = (id, screenName) => {
+  return {
+    name: 'user-profile',
+    params: (isExternal(screenName) ? { id } : { name: screenName })
+  }
 }
 
-const isExternal = ({screen_name}) => (screen_name.indexOf('@') > -1)
+const isExternal = screenName => (screenName.indexOf('@') > -1)
 
 export default generateProfileLink
diff --git a/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js b/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js
index dbb2ba9d..5718b8b9 100644
--- a/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js
+++ b/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js
@@ -2,14 +2,14 @@ import generateProfileLink from 'src/services/user_profile_link_generator/user_p
 
 describe('generateProfileLink', () => {
   it('returns obj for local user', () => {
-    const user = { screen_name: 'john' }
-
-    expect(generateProfileLink(user, 'jack')).to.eql({ name: 'user-profile', params: { name: 'jack' } })
+    expect(generateProfileLink(1, 'jack')).to.eql({
+      name: 'user-profile', params: { name: 'jack' }
+    })
   })
 
   it('returns obj for external user', () => {
-    const user = { screen_name: 'john@domain', id: 1 }
-
-    expect(generateProfileLink(user)).to.eql({ name: 'user-profile', params: { id: 1 } })
+    expect(generateProfileLink(1, 'john@domain')).to.eql({
+      name: 'user-profile', params: { id: 1 }
+    })
   })
 })
-- 
cgit v1.2.3-70-g09d2


From 1341a7bb9cc14ecd0a1755cd2de1c09384a431c6 Mon Sep 17 00:00:00 2001
From: Maxim Filippov <colixer@gmail.com>
Date: Thu, 13 Dec 2018 20:27:03 +0300
Subject: Use babel polyfill in karma

---
 package.json                                              |  1 +
 .../user_profile_link_generator.js                        |  2 +-
 test/unit/karma.conf.js                                   |  5 ++++-
 yarn.lock                                                 | 15 ++++++++++++++-
 4 files changed, 20 insertions(+), 3 deletions(-)

(limited to 'src/services')

diff --git a/package.json b/package.json
index 8f2a78a2..3a2ab212 100644
--- a/package.json
+++ b/package.json
@@ -35,6 +35,7 @@
     "whatwg-fetch": "^2.0.3"
   },
   "devDependencies": {
+    "@babel/polyfill": "^7.0.0",
     "@vue/test-utils": "^1.0.0-beta.26",
     "autoprefixer": "^6.4.0",
     "babel-core": "^6.0.0",
diff --git a/src/services/user_profile_link_generator/user_profile_link_generator.js b/src/services/user_profile_link_generator/user_profile_link_generator.js
index 3e245b15..9ae15792 100644
--- a/src/services/user_profile_link_generator/user_profile_link_generator.js
+++ b/src/services/user_profile_link_generator/user_profile_link_generator.js
@@ -5,6 +5,6 @@ const generateProfileLink = (id, screenName) => {
   }
 }
 
-const isExternal = screenName => (screenName.indexOf('@') > -1)
+const isExternal = screenName => screenName.includes('@')
 
 export default generateProfileLink
diff --git a/test/unit/karma.conf.js b/test/unit/karma.conf.js
index 89f21b2e..d19a2229 100644
--- a/test/unit/karma.conf.js
+++ b/test/unit/karma.conf.js
@@ -56,7 +56,10 @@ module.exports = function (config) {
     browsers: ['PhantomJS'],
     frameworks: ['mocha', 'sinon-chai'],
     reporters: ['mocha'],
-    files: ['./index.js'],
+    files: [
+      '../../node_modules/@babel/polyfill/dist/polyfill.js',
+      './index.js'
+    ],
     preprocessors: {
       './index.js': ['webpack', 'sourcemap']
     },
diff --git a/yarn.lock b/yarn.lock
index 832900fc..e0e98ed7 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -9,6 +9,14 @@
   dependencies:
     "@babel/types" "^7.0.0"
 
+"@babel/polyfill@^7.0.0":
+  version "7.0.0"
+  resolved "https://registry.yarnpkg.com/@babel/polyfill/-/polyfill-7.0.0.tgz#c8ff65c9ec3be6a1ba10113ebd40e8750fb90bff"
+  integrity sha512-dnrMRkyyr74CRelJwvgnnSUDh2ge2NCTyHVwpOdvRMHtJUyxLtMAfhBN3s64pY41zdw0kgiLPh6S20eb1NcX6Q==
+  dependencies:
+    core-js "^2.5.7"
+    regenerator-runtime "^0.11.1"
+
 "@babel/types@^7.0.0", "@babel/types@^7.0.0-beta.49":
   version "7.2.0"
   resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.2.0.tgz#7941c5b2d8060e06f9601d6be7c223eef906d5d8"
@@ -1583,7 +1591,7 @@ cookie@0.3.1:
   version "0.3.1"
   resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.3.1.tgz#e7e0a1f9ef43b4c8ba925c5c5a96e806d16873bb"
 
-core-js@^2.2.0:
+core-js@^2.2.0, core-js@^2.5.7:
   version "2.6.0"
   resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.6.0.tgz#1e30793e9ee5782b307e37ffa22da0eacddd84d4"
   integrity sha512-kLRC6ncVpuEW/1kwrOXYX6KQASCVtrh1gQr/UiaVgFlf9WE5Vp+lNe5+h3LuMr5PAucWnnEXwH0nQHRH/gpGtw==
@@ -5510,6 +5518,11 @@ regenerator-runtime@^0.11.0:
   version "0.11.0"
   resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.11.0.tgz#7e54fe5b5ccd5d6624ea6255c3473be090b802e1"
 
+regenerator-runtime@^0.11.1:
+  version "0.11.1"
+  resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.11.1.tgz#be05ad7f9bf7d22e056f9726cee5017fbf19e2e9"
+  integrity sha512-MguG95oij0fC3QV3URf4V2SDYGJhJnJGqvIIgdECeODCT98wSWDAJ94SSuVpYQUoTcGUIL6L4yNB7j1DFFHSBg==
+
 regenerator-transform@^0.10.0:
   version "0.10.1"
   resolved "https://registry.yarnpkg.com/regenerator-transform/-/regenerator-transform-0.10.1.tgz#1e4996837231da8b7f3cf4114d71b5691a0680dd"
-- 
cgit v1.2.3-70-g09d2


From 828b1c78f9304d400a206a25f4f43999bc5908bc Mon Sep 17 00:00:00 2001
From: Maxim Filippov <colixer@gmail.com>
Date: Sat, 15 Dec 2018 06:16:44 +0300
Subject: Implement user_profile.spec.js

---
 src/boot/routes.js                                 |   1 +
 src/components/status/status.js                    |   6 +-
 .../user_card_content/user_card_content.js         |   6 +-
 src/components/user_profile/user_profile.js        |  30 +++++-
 .../user_profile_link_generator.js                 |   2 +-
 test/unit/specs/boot/routes.spec.js                |   5 +-
 test/unit/specs/components/user_profile.spec.js    | 116 +++++++++++++++++++++
 .../user_profile_link_generator.spec.js            |   2 +-
 8 files changed, 153 insertions(+), 15 deletions(-)
 create mode 100644 test/unit/specs/components/user_profile.spec.js

(limited to 'src/services')

diff --git a/src/boot/routes.js b/src/boot/routes.js
index 9a249ee5..2a08934f 100644
--- a/src/boot/routes.js
+++ b/src/boot/routes.js
@@ -29,6 +29,7 @@ export default (store) => {
     { name: 'tag-timeline', path: '/~/tag/:tag', component: TagTimeline },
     { name: 'conversation', path: '/~/notice/:id', component: ConversationPage, meta: { dontScroll: true } },
     { name: 'user-profile', path: '/:name', component: UserProfile },
+    { name: 'external-user-profile', path: '/~/users/:id', component: UserProfile },
     { name: 'mentions', path: '/:username/mentions', component: Mentions },
     { name: 'dms', path: '/:username/dms', component: DMs },
     { name: 'settings', path: '/~/settings', component: Settings },
diff --git a/src/components/status/status.js b/src/components/status/status.js
index fbf99a23..94d03ec2 100644
--- a/src/components/status/status.js
+++ b/src/components/status/status.js
@@ -204,9 +204,6 @@ const Status = {
         return 'small'
       }
       return 'normal'
-    },
-    userProfileLink (id, name) {
-      return generateProfileLink(id, name)
     }
   },
   components: {
@@ -288,6 +285,9 @@ const Status = {
     },
     replyLeave () {
       this.showPreview = false
+    },
+    userProfileLink (id, name) {
+      return generateProfileLink(id, name)
     }
   },
   watch: {
diff --git a/src/components/user_card_content/user_card_content.js b/src/components/user_card_content/user_card_content.js
index abdac58e..cdb1a850 100644
--- a/src/components/user_card_content/user_card_content.js
+++ b/src/components/user_card_content/user_card_content.js
@@ -41,9 +41,6 @@ export default {
       const days = Math.ceil((new Date() - new Date(this.user.created_at)) / (60 * 60 * 24 * 1000))
       return Math.round(this.user.statuses_count / days)
     },
-    userProfileLink (user) {
-      return generateProfileLink(user.id, user.screen_name)
-    },
     userHighlightType: {
       get () {
         const data = this.$store.state.config.highlight[this.user.screen_name]
@@ -110,6 +107,9 @@ export default {
       if (target.tagName === 'A') {
         window.open(target.href, '_blank')
       }
+    },
+    userProfileLink (user) {
+      return generateProfileLink(user.id, user.screen_name)
     }
   }
 }
diff --git a/src/components/user_profile/user_profile.js b/src/components/user_profile/user_profile.js
index 8a32392a..95d797a2 100644
--- a/src/components/user_profile/user_profile.js
+++ b/src/components/user_profile/user_profile.js
@@ -3,19 +3,22 @@ import Timeline from '../timeline/timeline.vue'
 
 const UserProfile = {
   created () {
+    debugger
     this.$store.commit('clearTimeline', { timeline: 'user' })
-    this.$store.dispatch('startFetching', ['user', this.userName])
+    this.$store.dispatch('startFetching', ['user', this.fetchBy])
     if (!this.user) {
-      this.$store.dispatch('fetchUser', this.userName)
+      this.$store.dispatch('fetchUser', this.fetchBy)
     }
   },
   destroyed () {
     this.$store.dispatch('stopFetching', 'user')
   },
   computed: {
-    timeline () { return this.$store.state.statuses.timelines.user },
+    timeline () {
+      return this.$store.state.statuses.timelines.user
+    },
     userId () {
-      return this.user.id
+      return this.$route.params.id
     },
     userName () {
       return this.$route.params.name
@@ -25,16 +28,33 @@ const UserProfile = {
         return this.timeline.statuses[0].user
       } else {
         return Object.values(this.$store.state.users.usersObject).filter(user => {
-          return user.screen_name === this.userName
+          return (this.isExternal ? user.id === this.userId : user.screen_name === this.userName)
         })[0] || false
       }
+    },
+    fetchBy () {
+      return this.isExternal ? this.userId : this.userName
+    },
+    isExternal () {
+      return this.$route.name === 'external-user-profile'
     }
   },
   watch: {
     userName () {
+      if (this.isExternal) {
+        return
+      }
       this.$store.dispatch('stopFetching', 'user')
       this.$store.commit('clearTimeline', { timeline: 'user' })
       this.$store.dispatch('startFetching', ['user', this.userName])
+    },
+    userId () {
+      if (!this.isExternal) {
+        return
+      }
+      this.$store.dispatch('stopFetching', 'user')
+      this.$store.commit('clearTimeline', { timeline: 'user' })
+      this.$store.dispatch('startFetching', ['user', this.userId])
     }
   },
   components: {
diff --git a/src/services/user_profile_link_generator/user_profile_link_generator.js b/src/services/user_profile_link_generator/user_profile_link_generator.js
index 9ae15792..3367eb8a 100644
--- a/src/services/user_profile_link_generator/user_profile_link_generator.js
+++ b/src/services/user_profile_link_generator/user_profile_link_generator.js
@@ -1,6 +1,6 @@
 const generateProfileLink = (id, screenName) => {
   return {
-    name: 'user-profile',
+    name: (isExternal(screenName) ? 'external-user-profile' : 'user-profile'),
     params: (isExternal(screenName) ? { id } : { name: screenName })
   }
 }
diff --git a/test/unit/specs/boot/routes.spec.js b/test/unit/specs/boot/routes.spec.js
index be2fd7d2..638b1860 100644
--- a/test/unit/specs/boot/routes.spec.js
+++ b/test/unit/specs/boot/routes.spec.js
@@ -16,7 +16,7 @@ describe('routes', () => {
 
     const matchedComponents = router.getMatchedComponents()
 
-    expect(matchedComponents[0].components.hasOwnProperty('Timeline'))
+    expect(matchedComponents[0].components.hasOwnProperty('Timeline')).to.eql(true)
   })
 
   it('user\'s profile', () => {
@@ -24,6 +24,7 @@ describe('routes', () => {
 
     const matchedComponents = router.getMatchedComponents()
 
-    expect(matchedComponents[0].components.hasOwnProperty('UserProfile'))
+    console.log(matchedComponents[0].components.UserCardContent)
+    expect(matchedComponents[0].components.hasOwnProperty('UserProfile')).to.eql(true)
   })
 })
diff --git a/test/unit/specs/components/user_profile.spec.js b/test/unit/specs/components/user_profile.spec.js
new file mode 100644
index 00000000..b3497f30
--- /dev/null
+++ b/test/unit/specs/components/user_profile.spec.js
@@ -0,0 +1,116 @@
+import { mount, createLocalVue } from '@vue/test-utils'
+import Vuex from 'vuex'
+import UserProfile from 'src/components/user_profile/user_profile.vue'
+import backendInteractorService from 'src/services/backend_interactor_service/backend_interactor_service.js'
+
+const localVue = createLocalVue()
+localVue.use(Vuex)
+
+const mutations = {
+  clearTimeline: () => {}
+}
+
+const store = new Vuex.Store({
+  mutations,
+  state: {
+    api: {
+      backendInteractor: backendInteractorService('')
+    },
+    config: {
+      colors: '',
+      highlight: {}
+    },
+    instance: {
+      hideUserStats: true
+    },
+    statuses: {
+      timelines: {
+        user: {
+          statuses: [],
+          statusesObject: {},
+          faves: [],
+          visibleStatuses: [],
+          visibleStatusesObject: {},
+          newStatusCount: 0,
+          maxId: 0,
+          minVisibleId: 0,
+          loading: false,
+          followers: [],
+          friends: [],
+          viewing: 'statuses',
+          userId: 701,
+          flushMarker: 0
+        }
+      }
+    },
+    users: {
+      currentUser: {
+        credentials: ''
+      },
+      usersObject: [
+        {
+          background_image: null,
+          cover_photo: 'https://playvicious.social/system/accounts/headers/000/000/001/original/7dae4fc0e8330e83.jpg?1507329206',
+          created_at: 'Mon Dec 18 16:01:35 +0000 2017',
+          default_scope: 'public',
+          description: "Your favorite person's favorite person.",
+          description_html: "<p>Your favorite person's favorite person.</p>",
+          favourites_count: 0,
+          fields: [
+            {
+              name: '✌🏾',
+              value: '<a href="https://thetwelfth.house" rel="me nofollow noopener" target="_blank"><span class="invisible">https://</span><span class="">thetwelfth.house</span><span class="invisible"></span></a>'
+            },
+            {
+              name: '🚧',
+              value: '<a href="https://code.playvicio.us" rel="me nofollow noopener" target="_blank"><span class="invisible">https://</span><span class="">code.playvicio.us</span><span class="invisible"></span></a>'
+            },
+            {
+              name: '❤️',
+              value: '<a href="https://www.patreon.com/Are0h" rel="me nofollow noopener" target="_blank"><span class="invisible">https://www.</span><span class="">patreon.com/Are0h</span><span class="invisible"></span></a>'
+            }
+          ],
+          followers_count: 2,
+          following: false,
+          follows_you: false,
+          friends_count: 0,
+          id: 701,
+          is_local: false,
+          locked: false,
+          name: 'Are0h',
+          name_html: 'Are0h',
+          no_rich_text: false,
+          profile_image_url: 'https://playvicious.social/system/accounts/avatars/000/000/001/original/33e9983bc2d96aeb.png?1520872572',
+          profile_image_url_https: 'https://playvicious.social/system/accounts/avatars/000/000/001/original/33e9983bc2d96aeb.png?1520872572',
+          profile_image_url_original: 'https://playvicious.social/system/accounts/avatars/000/000/001/original/33e9983bc2d96aeb.png?1520872572',
+          profile_image_url_profile_size: 'https://playvicious.social/system/accounts/avatars/000/000/001/original/33e9983bc2d96aeb.png?1520872572',
+          rights: {
+            delete_others_notice: false
+          },
+          screen_name: 'Are0h@playvicious.social',
+          statuses_count: 6727,
+          statusnet_blocking: false,
+          statusnet_profile_url: 'https://playvicious.social/users/Are0h'
+        }
+      ]
+    }
+  }
+})
+
+describe('UserProfile', () => {
+  it('renders', () => {
+    const wrapper = mount(UserProfile, {
+      localVue,
+      store,
+      mocks: {
+        $route: {
+          params: { id: 701 },
+          name: 'external-user-profile'
+        },
+        $t: (msg) => msg
+      }
+    })
+
+    expect(wrapper.find('.user-screen-name').text()).to.eql('@Are0h@playvicious.social')
+  })
+})
diff --git a/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js b/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js
index 5718b8b9..4366f799 100644
--- a/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js
+++ b/test/unit/specs/services/user_profile_link_generator/user_profile_link_generator.spec.js
@@ -9,7 +9,7 @@ describe('generateProfileLink', () => {
 
   it('returns obj for external user', () => {
     expect(generateProfileLink(1, 'john@domain')).to.eql({
-      name: 'user-profile', params: { id: 1 }
+      name: 'external-user-profile', params: { id: 1 }
     })
   })
 })
-- 
cgit v1.2.3-70-g09d2


From 63ad08050ef54d2770260989de4b4b7b41c451ef Mon Sep 17 00:00:00 2001
From: Maxim Filippov <colixer@gmail.com>
Date: Mon, 17 Dec 2018 21:58:14 +0300
Subject: Fix oauth url

---
 src/services/new_api/oauth.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/services')

diff --git a/src/services/new_api/oauth.js b/src/services/new_api/oauth.js
index 9e656507..97dec94f 100644
--- a/src/services/new_api/oauth.js
+++ b/src/services/new_api/oauth.js
@@ -5,7 +5,7 @@ const getOrCreateApp = ({oauth, instance}) => {
   const form = new window.FormData()
 
   form.append('client_name', `PleromaFE_${Math.random()}`)
-  form.append('redirect_uris', `${window.location.origin}/oauth-callback`)
+  form.append('redirect_uris', `${window.location.origin}/~/oauth-callback`)
   form.append('scopes', 'read write follow')
 
   return window.fetch(url, {
@@ -64,7 +64,7 @@ const getToken = ({app, instance, code}) => {
   form.append('client_secret', app.client_secret)
   form.append('grant_type', 'authorization_code')
   form.append('code', code)
-  form.append('redirect_uri', `${window.location.origin}/oauth-callback`)
+  form.append('redirect_uri', `${window.location.origin}/~/oauth-callback`)
 
   return window.fetch(url, {
     method: 'POST',
-- 
cgit v1.2.3-70-g09d2