From fca885e665094b8efcbc65a3f4ec9ba31679c4c2 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Sun, 25 Apr 2021 13:23:16 +0300 Subject: resolve TODO VUE3 --- src/components/status_popover/status_popover.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/components/status_popover/status_popover.js') diff --git a/src/components/status_popover/status_popover.js b/src/components/status_popover/status_popover.js index c47f5631..e0962ccd 100644 --- a/src/components/status_popover/status_popover.js +++ b/src/components/status_popover/status_popover.js @@ -1,6 +1,7 @@ import { find } from 'lodash' import { library } from '@fortawesome/fontawesome-svg-core' import { faCircleNotch } from '@fortawesome/free-solid-svg-icons' +import { defineAsyncComponent } from 'vue' library.add( faCircleNotch @@ -22,8 +23,8 @@ const StatusPopover = { } }, components: { - Status: () => import('../status/status.vue'), - Popover: () => import('../popover/popover.vue') + Status: defineAsyncComponent(() => import('../status/status.vue')), + Popover: defineAsyncComponent(() => import('../popover/popover.vue')) }, methods: { enter () { -- cgit v1.2.3-70-g09d2 From a0ddfa499fe45e352e8c3920cba862a4902f0afe Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 22 Jun 2022 00:34:22 +0300 Subject: update status popover when its content changes (only status reference) --- src/components/status_popover/status_popover.js | 7 +++++++ src/components/status_popover/status_popover.vue | 1 + 2 files changed, 8 insertions(+) (limited to 'src/components/status_popover/status_popover.js') diff --git a/src/components/status_popover/status_popover.js b/src/components/status_popover/status_popover.js index e0962ccd..68878a50 100644 --- a/src/components/status_popover/status_popover.js +++ b/src/components/status_popover/status_popover.js @@ -38,6 +38,13 @@ const StatusPopover = { .catch(e => (this.error = true)) } } + }, + watch: { + status (newStatus, oldStatus) { + if (newStatus !== oldStatus) { + this.$refs.popover.updateStyles() + } + } } } diff --git a/src/components/status_popover/status_popover.vue b/src/components/status_popover/status_popover.vue index b6a3be32..2c436d04 100644 --- a/src/components/status_popover/status_popover.vue +++ b/src/components/status_popover/status_popover.vue @@ -4,6 +4,7 @@ popover-class="popover-default status-popover" :bound-to="{ x: 'container' }" @show="enter" + ref="popover" >