From 3cba358743cd2c1d92b487295774231cef68978d Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 21 Dec 2022 23:45:35 +0200 Subject: fix nested properties watcher being triggered far too often --- src/components/settings_modal/helpers/boolean_setting.js | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/components/settings_modal/helpers/boolean_setting.js') diff --git a/src/components/settings_modal/helpers/boolean_setting.js b/src/components/settings_modal/helpers/boolean_setting.js index dc832044..2e6992cb 100644 --- a/src/components/settings_modal/helpers/boolean_setting.js +++ b/src/components/settings_modal/helpers/boolean_setting.js @@ -41,7 +41,13 @@ export default { }, methods: { update (e) { + const [firstSegment, ...rest] = this.path.split('.') set(this.$parent, this.path, e) + // Updating nested properties does not trigger update on its parent. + // probably still not as reliable, but works for depth=1 at least + if (rest.length > 0) { + set(this.$parent, firstSegment, { ...get(this.$parent, firstSegment) }) + } }, reset () { set(this.$parent, this.path, this.defaultState) -- cgit v1.2.3-70-g09d2