From d2a74ea1a2965eb38609bb8029a41b45beab89ce Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 7 Feb 2024 15:53:49 +0200 Subject: add .input class to all inputs --- src/components/checkbox/checkbox.vue | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) (limited to 'src/components/checkbox/checkbox.vue') diff --git a/src/components/checkbox/checkbox.vue b/src/components/checkbox/checkbox.vue index b8b77e7c..9739c08b 100644 --- a/src/components/checkbox/checkbox.vue +++ b/src/components/checkbox/checkbox.vue @@ -12,7 +12,7 @@ @change="$emit('update:modelValue', $event.target.checked)" > @@ -62,9 +62,15 @@ export default { display: inline-block; min-height: 1.2em; - &-indicator { + & > &-indicator { + /* Reset .input stuff */ + padding: 0; + margin: 0; position: relative; + line-height: inherit; + display: inline; padding-left: 1.2em; + box-shadow: none; } &-indicator::before { @@ -78,10 +84,8 @@ export default { height: 1.1em; border-radius: $fallback--checkboxRadius; border-radius: var(--checkboxRadius, $fallback--checkboxRadius); - box-shadow: 0 0 2px black inset; - box-shadow: var(--inputShadow); - background-color: $fallback--fg; - background-color: var(--input, $fallback--fg); + box-shadow: var(--shadow); + background-color: var(--background); vertical-align: top; text-align: center; line-height: 1.1em; @@ -98,21 +102,18 @@ export default { } .label { - color: $fallback--faint; - color: var(--faint, $fallback--faint); + color: var(--text); } } input[type="checkbox"] { &:checked + .checkbox-indicator::before { - color: $fallback--text; - color: var(--inputText, $fallback--text); + color: var(--text); } &:indeterminate + .checkbox-indicator::before { content: "–"; - color: $fallback--text; - color: var(--inputText, $fallback--text); + color: var(--text); } } -- cgit v1.2.3-70-g09d2 From f609aaba0c9a7c4d3c3d579a2a0021ecd5fc4028 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Wed, 21 Feb 2024 13:10:11 +0200 Subject: improve checkbox styles --- src/components/checkbox/checkbox.vue | 5 ++--- src/components/font_control/font_control.vue | 2 +- src/components/input.style.js | 10 ++++++++++ src/components/poll/poll.vue | 4 ++-- src/components/range_input/range_input.vue | 2 +- src/components/shadow_control/shadow_control.vue | 2 +- src/services/theme_data/theme2_to_theme3.js | 10 +++++----- 7 files changed, 22 insertions(+), 13 deletions(-) (limited to 'src/components/checkbox/checkbox.vue') diff --git a/src/components/checkbox/checkbox.vue b/src/components/checkbox/checkbox.vue index 9739c08b..eac79199 100644 --- a/src/components/checkbox/checkbox.vue +++ b/src/components/checkbox/checkbox.vue @@ -12,7 +12,7 @@ @change="$emit('update:modelValue', $event.target.checked)" > @@ -82,8 +82,7 @@ export default { transition: color 200ms; width: 1.1em; height: 1.1em; - border-radius: $fallback--checkboxRadius; - border-radius: var(--checkboxRadius, $fallback--checkboxRadius); + border-radius: var(--roundness); box-shadow: var(--shadow); background-color: var(--background); vertical-align: top; diff --git a/src/components/font_control/font_control.vue b/src/components/font_control/font_control.vue index b90fba56..d5e63578 100644 --- a/src/components/font_control/font_control.vue +++ b/src/components/font_control/font_control.vue @@ -14,7 +14,7 @@ v-if="typeof fallback !== 'undefined'" :id="name + '-o'" :aria-labelledby="name + '-label'" - class="input opt exlcude-disabled visible-for-screenreader-only" + class="input -checkbox opt exlcude-disabled visible-for-screenreader-only" type="checkbox" :checked="present" @change="$emit('update:modelValue', typeof modelValue === 'undefined' ? fallback : undefined)" diff --git a/src/components/input.style.js b/src/components/input.style.js index 985d5412..b1c9f3db 100644 --- a/src/components/input.style.js +++ b/src/components/input.style.js @@ -12,6 +12,10 @@ const hoverGlow = { export default { name: 'Input', selector: '.input', + variant: { + checkbox: '.-checkbox', + radio: '.-radio' + }, states: { disabled: ':disabled', hover: ':hover:not(:disabled)', @@ -21,6 +25,12 @@ export default { 'Text' ], defaultRules: [ + { + variant: 'checkbox', + directives: { + roundness: 1 + } + }, { directives: { background: '--fg, -5', diff --git a/src/components/poll/poll.vue b/src/components/poll/poll.vue index 087822e1..57ec879a 100644 --- a/src/components/poll/poll.vue +++ b/src/components/poll/poll.vue @@ -43,7 +43,7 @@ @@ -52,7 +52,7 @@ type="radio" :disabled="loading" :value="index" - class="input" + class="input -radio" >