From 7b99d98c553f40ec4d633d0d4fdf65f275c80e77 Mon Sep 17 00:00:00 2001 From: Shpuld Shpuldson Date: Tue, 24 Nov 2020 12:32:42 +0200 Subject: Replace all use of + href='#' with proper buttons --- src/App.scss | 32 +++++++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-) (limited to 'src/App.scss') diff --git a/src/App.scss b/src/App.scss index ca7d33cd..ef2a13b1 100644 --- a/src/App.scss +++ b/src/App.scss @@ -33,6 +33,7 @@ h4 { max-width: 980px; align-content: flex-start; } + .underlay { background-color: rgba(0,0,0,0.15); background-color: var(--underlay, rgba(0,0,0,0.15)); @@ -69,7 +70,7 @@ a { color: var(--link, $fallback--link); } -button { +.button-default { user-select: none; color: $fallback--text; color: var(--btnText, $fallback--text); @@ -85,7 +86,9 @@ button { font-family: sans-serif; font-family: var(--interfaceFont, sans-serif); - i[class*=icon-], .svg-inline--fa { + i[class*=icon-], + :not(&.-icon), + .svg-inline--fa { color: $fallback--text; color: var(--btnText, $fallback--text); } @@ -149,6 +152,29 @@ button { } } +.button-unstyled { + background: none; + border: none; + outline: none; + display: inline; + text-align: initial; + font-size: 100%; + font-family: inherit; + padding: 0; + line-height: unset; + cursor: pointer; + + &.-link { + color: $fallback--link; + color: var(--link, $fallback--link); + } + + &.-padded { + padding: 5px; + margin: -5px; + } +} + input, textarea, .select, .input { &.unstyled { @@ -797,7 +823,7 @@ nav { } } -.btn.btn-default { +.btn.button-default { min-height: 28px; } -- cgit v1.2.3-70-g09d2 From 8b775f94a99b4cdda2c8581d1803a0599c8b0e3a Mon Sep 17 00:00:00 2001 From: Shpuld Shpuldson Date: Tue, 24 Nov 2020 14:52:01 +0200 Subject: more fixes, add fullwidth --- src/App.scss | 34 +++++++++++++++--------- src/components/emoji_input/emoji_input.vue | 6 ++--- src/components/extra_buttons/extra_buttons.vue | 10 ++++--- src/components/notifications/notifications.vue | 2 +- src/components/popover/popover.js | 2 +- src/components/popover/popover.vue | 5 ++-- src/components/react_button/react_button.vue | 13 ++++----- src/components/scope_selector/scope_selector.vue | 24 ++++++++--------- src/components/side_drawer/side_drawer.vue | 5 ++-- src/components/timeline/timeline.vue | 2 +- src/components/timeline_menu/timeline_menu.vue | 1 + src/hocs/with_load_more/with_load_more.js | 6 ++++- 12 files changed, 63 insertions(+), 47 deletions(-) (limited to 'src/App.scss') diff --git a/src/App.scss b/src/App.scss index ef2a13b1..1d0abb51 100644 --- a/src/App.scss +++ b/src/App.scss @@ -163,6 +163,8 @@ a { padding: 0; line-height: unset; cursor: pointer; + box-sizing: content-box; + color: inherit; &.-link { color: $fallback--link; @@ -170,8 +172,12 @@ a { } &.-padded { - padding: 5px; - margin: -5px; + padding: 10px; + margin: -10px; + } + + &.-fullwidth { + width: 100%; } } @@ -468,6 +474,7 @@ main-router { color: $fallback--faint; color: var(--panelFaint, $fallback--faint); } + .faint-link { color: $fallback--faint; color: var(--faintLink, $fallback--faint); @@ -479,11 +486,8 @@ main-router { overflow-x: hidden; } - button { - flex-shrink: 0; - } - - button, .alert { + .button-default, + .alert { // height: 100%; line-height: 21px; min-height: 0; @@ -494,8 +498,11 @@ main-router { align-self: stretch; } - button { - &, i[class*=icon-] { + .button-default { + flex-shrink: 0; + + &, + i[class*=icon-] { color: $fallback--text; color: var(--btnPanelText, $fallback--text); } @@ -518,7 +525,8 @@ main-router { } } - a { + a, + .-link { color: $fallback--link; color: var(--panelLink, $fallback--link) } @@ -533,15 +541,15 @@ main-router { border-radius: 0 0 $fallback--panelRadius $fallback--panelRadius; border-radius: 0 0 var(--panelRadius, $fallback--panelRadius) var(--panelRadius, $fallback--panelRadius); - .faint { color: $fallback--faint; color: var(--panelFaint, $fallback--faint); } - a { + a, + .-link { color: $fallback--link; - color: var(--panelLink, $fallback--link) + color: var(--panelLink, $fallback--link); } } diff --git a/src/components/emoji_input/emoji_input.vue b/src/components/emoji_input/emoji_input.vue index 224e72cf..d308bf86 100644 --- a/src/components/emoji_input/emoji_input.vue +++ b/src/components/emoji_input/emoji_input.vue @@ -6,13 +6,13 @@ > @@ -117,6 +117,8 @@ .ExtraButtons { cursor: pointer; position: static; + padding: 10px; + margin: -10px; &:hover .svg-inline--fa { color: $fallback--text; diff --git a/src/components/notifications/notifications.vue b/src/components/notifications/notifications.vue index 663f623b..725d1ad4 100644 --- a/src/components/notifications/notifications.vue +++ b/src/components/notifications/notifications.vue @@ -43,7 +43,7 @@
- + @@ -105,8 +104,10 @@ } } -.add-reaction-button { +.AddReaction { cursor: pointer; + padding: 10px; + margin: -10px; &:hover .svg-inline--fa { color: $fallback--text; diff --git a/src/components/scope_selector/scope_selector.vue b/src/components/scope_selector/scope_selector.vue index a22a4fda..66ac612e 100644 --- a/src/components/scope_selector/scope_selector.vue +++ b/src/components/scope_selector/scope_selector.vue @@ -3,9 +3,9 @@ v-if="!showNothing" class="ScopeSelector" > - - - + diff --git a/src/components/side_drawer/side_drawer.vue b/src/components/side_drawer/side_drawer.vue index 1c14c1ab..695ae03b 100644 --- a/src/components/side_drawer/side_drawer.vue +++ b/src/components/side_drawer/side_drawer.vue @@ -145,7 +145,7 @@
  • + } {!this.error && this.loading && } {!this.error && !this.loading && !this.bottomedOut && {this.$t('general.more')}} -- cgit v1.2.3-70-g09d2 From a6e495e4138e80888ea77e144f0330cd83d4a986 Mon Sep 17 00:00:00 2001 From: Shpuld Shpuldson Date: Tue, 24 Nov 2020 16:10:03 +0200 Subject: fix warnings --- src/App.scss | 2 +- src/components/notification/notification.vue | 10 ++++++---- src/components/timeline/timeline.vue | 4 +++- 3 files changed, 10 insertions(+), 6 deletions(-) (limited to 'src/App.scss') diff --git a/src/App.scss b/src/App.scss index 1d0abb51..76a5e797 100644 --- a/src/App.scss +++ b/src/App.scss @@ -71,7 +71,6 @@ a { } .button-default { - user-select: none; color: $fallback--text; color: var(--btnText, $fallback--text); background-color: $fallback--fg; @@ -85,6 +84,7 @@ a { font-size: 14px; font-family: sans-serif; font-family: var(--interfaceFont, sans-serif); + user-select: none; i[class*=icon-], :not(&.-icon), diff --git a/src/components/notification/notification.vue b/src/components/notification/notification.vue index ba3648fd..08eb80c9 100644 --- a/src/components/notification/notification.vue +++ b/src/components/notification/notification.vue @@ -135,10 +135,12 @@ v-if="needMute" class="button-unstyled" @click.prevent="toggleMute" - > + > + +