diff options
| author | Henry Jameson <me@hjkos.com> | 2021-05-31 14:16:37 +0300 |
|---|---|---|
| committer | Henry Jameson <me@hjkos.com> | 2021-05-31 14:16:37 +0300 |
| commit | e95412a03cb84d4d835047d44e55a2900cdfb0d1 (patch) | |
| tree | fe1c756b4df7bc063b42e652d6cfd01c497f55b1 /src | |
| parent | 4e96af044224dc10b8cc4eb270e025f1b8a1d29a (diff) | |
fix BooleanSetting and ChoiceSetting not working properly on initial
launch as anon visitor (would show all as changed, empty selects)
Diffstat (limited to 'src')
| -rw-r--r-- | src/components/settings_modal/helpers/boolean_setting.js | 5 | ||||
| -rw-r--r-- | src/components/settings_modal/helpers/choice_setting.js | 4 |
2 files changed, 6 insertions, 3 deletions
diff --git a/src/components/settings_modal/helpers/boolean_setting.js b/src/components/settings_modal/helpers/boolean_setting.js index 1dda49f2..dea77e10 100644 --- a/src/components/settings_modal/helpers/boolean_setting.js +++ b/src/components/settings_modal/helpers/boolean_setting.js @@ -18,8 +18,11 @@ export default { state () { return get(this.$parent, this.path) }, + defaultState () { + return get(this.$parent, this.pathDefault) + }, isChanged () { - return get(this.$parent, this.path) !== get(this.$parent, this.pathDefault) + return this.state !== undefined && this.state !== this.defaultState } }, methods: { diff --git a/src/components/settings_modal/helpers/choice_setting.js b/src/components/settings_modal/helpers/choice_setting.js index 042e8106..f4387e62 100644 --- a/src/components/settings_modal/helpers/choice_setting.js +++ b/src/components/settings_modal/helpers/choice_setting.js @@ -17,13 +17,13 @@ export default { return [firstSegment + 'DefaultValue', ...rest].join('.') }, state () { - return get(this.$parent, this.path) + return get(this.$parent, this.path) || get(this.$parent, this.pathDefault) }, defaultState () { return get(this.$parent, this.pathDefault) }, isChanged () { - return get(this.$parent, this.path) !== get(this.$parent, this.pathDefault) + return this.state !== undefined && this.state !== this.defaultState } }, methods: { |
