Refactor visibleRole for better readability

Improve translation

1 files changed, 3 insertions, 12 deletions

diff --git a/src/components/user_card_content/user_card_content.js b/src/components/user_card_content/user_card_content.js
index 427cb32d..1888f8c6 100644
--- a/src/components/user_card_content/user_card_content.js
+++ b/src/components/user_card_content/user_card_content.js
@@ -81,19 +81,10 @@ export default {
       }
     },
     visibleRole () {
-      const user = this.user
+      const validRole = (this.user.role === 'admin' || this.user.role === 'moderator')
+      const showRole = this.isOtherUser || this.user.show_role
 
-      if (!(user.role === 'admin' || user.role === 'moderator')) {
-        return undefined
-      }
-
-      if (this.isOtherUser) {
-        return user.role
-      }
-
-      if (user.show_role) {
-        return user.role
-      }
+      return validRole && showRole && this.user.role
     }
   },
   components: {