aboutsummaryrefslogtreecommitdiff
path: root/src/components/shadow_control
diff options
context:
space:
mode:
authorHenry Jameson <me@hjkos.com>2018-11-20 23:25:38 +0300
committerHenry Jameson <me@hjkos.com>2018-11-20 23:25:38 +0300
commitd7af2c8419df59d8b897bc57e94f6cc67bd60eca (patch)
tree5f3faba14976c996086afa8a58f56d6beb1259df /src/components/shadow_control
parent2609c0d0d279031cba579d60bf94cca81544ec4f (diff)
mentioned bug in tab-switcher, made shadow-control work in zero-state
Diffstat (limited to 'src/components/shadow_control')
-rw-r--r--src/components/shadow_control/shadow_control.js19
-rw-r--r--src/components/shadow_control/shadow_control.vue7
2 files changed, 16 insertions, 10 deletions
diff --git a/src/components/shadow_control/shadow_control.js b/src/components/shadow_control/shadow_control.js
index 54813685..b4f48668 100644
--- a/src/components/shadow_control/shadow_control.js
+++ b/src/components/shadow_control/shadow_control.js
@@ -37,9 +37,12 @@ export default {
this.selectedId += 1
}
},
+ beforeUpdate () {
+ this.cValue = this.value || this.fallback
+ },
computed: {
selected () {
- return this.cValue[this.selectedId] || {
+ return this.isReady && this.cValue[this.selectedId] || {
x: 0,
y: 0,
blur: 0,
@@ -50,13 +53,17 @@ export default {
}
},
moveUpValid () {
- return this.selectedId > 0
+ return this.isReady && this.selectedId > 0
},
moveDnValid () {
- return this.selectedId < this.cValue.length - 1
+ return this.isReady && this.selectedId < this.cValue.length - 1
+ },
+ isReady () {
+ return typeof this.cValue !== 'undefined'
},
present () {
- return typeof this.cValue[this.selectedId] !== 'undefined' &&
+ return this.isReady &&
+ typeof this.cValue[this.selectedId] !== 'undefined' &&
!this.usingFallback
},
usingFallback () {
@@ -66,9 +73,9 @@ export default {
return hex2rgb(this.selected.color)
},
style () {
- return {
+ return this.isReady ? {
boxShadow: getCssShadow(this.cValue)
- }
+ } : {}
}
}
}
diff --git a/src/components/shadow_control/shadow_control.vue b/src/components/shadow_control/shadow_control.vue
index cd774d32..f8066947 100644
--- a/src/components/shadow_control/shadow_control.vue
+++ b/src/components/shadow_control/shadow_control.vue
@@ -43,7 +43,7 @@
<label for="shadow-switcher" class="select">
<select
v-model="selectedId" class="shadow-switcher"
- :disabled="usingFallback"
+ :disabled="!isReady || usingFallback"
id="shadow-switcher">
<option v-for="(shadow, index) in cValue" :value="index">
{{$t('settings.style.shadows.shadow_id', { value: index })}}
@@ -51,7 +51,7 @@
</select>
<i class="icon-down-open"/>
</label>
- <button class="btn btn-default" :disabled="!present" @click="del">
+ <button class="btn btn-default" :disabled="!isReady || !present" @click="del">
<i class="icon-cancel"/>
</button>
<button class="btn btn-default" :disabled="!moveUpValid" @click="moveUp">
@@ -60,7 +60,7 @@
<button class="btn btn-default" :disabled="!moveDnValid" @click="moveDn">
<i class="icon-down-open"/>
</button>
- <button class="btn btn-default" @click="add">
+ <button class="btn btn-default" :disabled="!isReady" @click="add">
<i class="icon-plus"/>
</button>
</div>
@@ -137,7 +137,6 @@
flex-wrap: wrap;
justify-content: center;
-
.shadow-preview-container,
.shadow-tweak {
margin: 5px 6px 0 0;