diff options
| author | Henry Jameson <me@hjkos.com> | 2019-03-30 12:25:23 +0200 |
|---|---|---|
| committer | Henry Jameson <me@hjkos.com> | 2019-03-30 12:25:23 +0200 |
| commit | bf927122df94853593a000ae873e8c840674258f (patch) | |
| tree | 993c7e8b375af67d794ab8bb809e4b701f6a9891 | |
| parent | 6184c88ac70b33e66a87222142344f693406bd87 (diff) | |
Review
| -rw-r--r-- | BREAKING_CHANGES.md | 6 | ||||
| -rw-r--r-- | src/components/post_status_form/post_status_form.vue | 1 | ||||
| -rw-r--r-- | src/components/scope_selector/scope_selector.js | 3 |
3 files changed, 7 insertions, 3 deletions
diff --git a/BREAKING_CHANGES.md b/BREAKING_CHANGES.md new file mode 100644 index 00000000..915aa74c --- /dev/null +++ b/BREAKING_CHANGES.md @@ -0,0 +1,6 @@ +# v1.0 +## Removed features/radically changed behavior +* As of !633, `scopeOptions` is no longer available and instead is changed for `scopeOptionsMinimal` (default: `false`) +Reasoning is that scopeOptions option originally existed mostly as a backwards-compatibility with GNU Social which only had `public` scope available and using scope selector would''t work. Since at some point we dropped GNU Social support, this option was mostly a nuisance (being default `false`'), however some people think scopes are an annoyance to a certain degree and want as less of that feature as possible. +Solution - to only show minimal set among: *Direct*, *User default* and *Scope of post replying to*. This also makes it impossible to reply to a DM with a non-DM post from UI. +*This setting is admin-default, user-configurable. Admin can choose different default for their instance but user can override it.* diff --git a/src/components/post_status_form/post_status_form.vue b/src/components/post_status_form/post_status_form.vue index b3d731cd..8beb73a9 100644 --- a/src/components/post_status_form/post_status_form.vue +++ b/src/components/post_status_form/post_status_form.vue @@ -46,7 +46,6 @@ <scope-selector :showAll="showAllScopes" - :userEnabled="['direct']" :userDefault="userDefaultScope" :originalScope="copyMessageScope" :initialScope="newStatus.visibility" diff --git a/src/components/scope_selector/scope_selector.js b/src/components/scope_selector/scope_selector.js index 578f1ba5..4693d066 100644 --- a/src/components/scope_selector/scope_selector.js +++ b/src/components/scope_selector/scope_selector.js @@ -1,7 +1,6 @@ const ScopeSelector = { props: [ 'showAll', - 'userEnabled', 'userDefault', 'originalScope', 'initialScope', @@ -43,7 +42,7 @@ const ScopeSelector = { this.currentScope === scope || this.originalScope === scope || this.userDefault === scope || - this.userEnabled.includes(scope) + 'direct' === scope }, changeVis (scope) { this.currentScope = scope |